crypto/rand: add syscall number fallbacks in seccomp_linux #90
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seccomp_linux.go is only used for Go's own tests (commit 6446285), but the package is included when building programs with CGO_ENABLED=1. When using an older glibc (e.g. 2.17), SYS_getrandom and SYS_seccomp are not defined, causing cgo compilation to fail. Note that there are already several types and defines copied from linux headers into seccomp_linux.go to support compilation on older systems.
austinderek
force-pushed
the
seccomp_linux_syscall_fallback
branch
from
08e6cdc to
0a0020e
Compare
austinderek
force-pushed
the
master
branch
26 times, most recently
from
38b1a42 to
db10db6
Compare
austinderek
force-pushed
the
master
branch
24 times, most recently
from
29d43df to
08ee556
Compare
PullRequest network review has been cancelledYou can reactivate the code review job from the PullRequest dashboard - or - by adding [pr] to the title of this code review. |
HackerOne Code Security Review🟢 Scan Complete: 1 Issue(s) Here's how the code changes were interpreted and info about the tools used for scanning. 📖 Summary of ChangesThe changes involve adding preprocessor definitions for system calls SYS_getrandom and SYS_seccomp with default values of -1 in the seccomp_linux.go file. A new check was implemented in the disable_getrandom() function to return early and provide an error code of 3 if either syscall is undefined, potentially improving error handling for system-specific random number generation and seccomp operations.
ℹ️ Issues DetectedNOTE: These may not require action! Below are unvalidated results from the Analysis Tools that ran during the latest scan for transparency. We investigate each of these for accuracy and relevance before surfacing them as a potential problem. How will I know if something is a problem?
🧰 Analysis tools
⏱️ Latest scan covered changes up to commit 412c349 (latest) |
austinderek
force-pushed
the
master
branch
4 times, most recently
from
d09a8c8 to
08ee556
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seccomp_linux.go is only used for Go's own tests (commit 6446285), but the package is included when building programs with CGO_ENABLED=1.
When using an older glibc (e.g. 2.17), SYS_getrandom and SYS_seccomp are not defined, causing cgo compilation to fail.
Note that there are already several types and defines copied from linux headers into seccomp_linux.go to support compilation on older systems.
Updates golang#69536
🔄 This is a mirror of upstream PR golang#75658